Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IDataConsumer for the TestHostController #2811

Merged
merged 3 commits into from
May 4, 2024

Conversation

MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli commented May 4, 2024

Make the IDataConsumer registration symmetric in both model. Historically we added a way to have data consumer inside the test host for "questionable" trx needs.

So we were foreaching the extension and in case of IDataConsumer implementation we were adding as listener to the IMessageBus to allow for instance the codecov old version to push the file that the trx could take to put inside the report self.

Nowadays where we run the trx and cc in-process this is mostly non needed but anyway we have a feature to collect artifacts inside the test host controller to "add attachments" if someone there is producing something.
This is an "hidden" and not documented behavior used only by our trx extension. So it's fine to update and make it coherent with the rest, but won't be exposed yet and most probably never. I don't know if we will never have reason to do it. The logic is that outside you push artifacts and stop, like the current VSTest logger, so I would not expose this feature but for now I'll internalize the method only to keep the current trx behavior.

I'll update the trx extension as soon as we'll flow this there.

cc: @Evangelink wait the trx update on the other side before to ship

Marco Rossignoli added 2 commits May 4, 2024 16:39
@MarcoRossignoli MarcoRossignoli merged commit 1aa3595 into microsoft:main May 4, 2024
6 checks passed
@MarcoRossignoli MarcoRossignoli deleted the dev/mr/dataconsumer branch May 4, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant