Refactor IDataConsumer
for the TestHostController
#2811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
IDataConsumer
registration symmetric in both model. Historically we added a way to have data consumer inside the test host for "questionable" trx needs.So we were foreaching the extension and in case of
IDataConsumer
implementation we were adding as listener to theIMessageBus
to allow for instance the codecov old version to push the file that the trx could take to put inside the report self.Nowadays where we run the trx and cc in-process this is mostly non needed but anyway we have a feature to collect artifacts inside the test host controller to "add attachments" if someone there is producing something.
This is an "hidden" and not documented behavior used only by our trx extension. So it's fine to update and make it coherent with the rest, but won't be exposed yet and most probably never. I don't know if we will never have reason to do it. The logic is that outside you push artifacts and stop, like the current VSTest logger, so I would not expose this feature but for now I'll internalize the method only to keep the current trx behavior.
I'll update the trx extension as soon as we'll flow this there.
cc: @Evangelink wait the trx update on the other side before to ship