Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to override GetDisplayName method from DataRowAttribute #1413

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Allow to override GetDisplayName method from DataRowAttribute #1413

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
383a52a
Allow to override GetDisplayName method from DataRowAttribute
engyebrahim Nov 28, 2022
5412404
fix
engyebrahim Nov 28, 2022
3725089
add test
engyebrahim Nov 30, 2022
3d80edd
applied PR's commit
engyebrahim Nov 30, 2022
1565b15
added integration tests
engyebrahim Nov 30, 2022
a27eaea
fix
engyebrahim Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TestFramework/TestFramework/Attributes/DataSource/DataRowAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public DataRowAttribute(params object?[]? data)
}

/// <inheritdoc />
public string? GetDisplayName(MethodInfo methodInfo, object?[]? data)
public virtual string? GetDisplayName(MethodInfo methodInfo, object?[]? data)
{
if (!string.IsNullOrWhiteSpace(DisplayName))
{
Expand Down
1 change: 0 additions & 1 deletion src/TestFramework/TestFramework/PublicAPI/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ Microsoft.VisualStudio.TestTools.UnitTesting.DataRowAttribute.DataRowAttribute(p
Microsoft.VisualStudio.TestTools.UnitTesting.DataRowAttribute.DisplayName.get -> string?
Microsoft.VisualStudio.TestTools.UnitTesting.DataRowAttribute.DisplayName.set -> void
Microsoft.VisualStudio.TestTools.UnitTesting.DataRowAttribute.GetData(System.Reflection.MethodInfo! methodInfo) -> System.Collections.Generic.IEnumerable<object?[]!>!
Microsoft.VisualStudio.TestTools.UnitTesting.DataRowAttribute.GetDisplayName(System.Reflection.MethodInfo! methodInfo, object?[]? data) -> string?
Microsoft.VisualStudio.TestTools.UnitTesting.DataSourceAttribute
Microsoft.VisualStudio.TestTools.UnitTesting.DataSourceAttribute.ConnectionString.get -> string?
Microsoft.VisualStudio.TestTools.UnitTesting.DataSourceAttribute.DataAccessMethod.get -> Microsoft.VisualStudio.TestTools.UnitTesting.DataAccessMethod
Expand Down
2 changes: 1 addition & 1 deletion src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@

virtual Microsoft.VisualStudio.TestTools.UnitTesting.DataRowAttribute.GetDisplayName(System.Reflection.MethodInfo! methodInfo, object?[]? data) -> string?