Add support for AsyncDisposable cleanup #1288
Conversation
Evangelink
changed the title
There was a problem hiding this comment.
That's a super good work @engyebrahim!
A few extra comments:
-
Try to have a more "functional" title to your PRs so that it's easier to understand what PR is bringing without having to look at the implementation.
-
The implementation with dummies and static Func/Action is a good idea but we need to be careful with them! If we add a new test reusing the dummy and the two tests are executed in parallel we might have test failure because the actual body was changed by another test. I need to investigate if we could do something similar to roslyn/roslyn-analyzers where we would compile classes on the fly and execute the content.
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestMethodInfoTests.cs
Outdated
Show resolved
Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestMethodInfoTests.cs
Outdated
Show resolved
Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestMethodInfoTests.cs
Outdated
Show resolved
Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestMethodInfoTests.cs
Outdated
Show resolved
Hide resolved
|
Can you please update the docs with an example of what has been made possible? |
|
@abatishchev Sure! May I ask which doc you are referring to? |
|
@Evangelink that's what I'm looking for, any doc that would shed light on the new feature. The release notes only point to this issue. I couldn't find a sample or anything like that. |
|
Yeah right. I will add that to my TODOs, current docs for mstest are pretty poor and outdated. |
fix: #1164