Add Assert.IsInstanceOfType<T> #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs # src/TestFramework/MSTest.Core/Assertions/Assert.cs # test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.AreEqualTests.cs # test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.IsInstanceOfTypeTests.cs
Evangelink
reviewed
Sep 12, 2022
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.AreEqualTests.cs
Outdated
Show resolved
Hide resolved
Haplois
suggested changes
Sep 13, 2022
test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.IsInstanceOfTypeTests.cs
Outdated
Show resolved
Hide resolved
test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.IsInstanceOfTypeTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Sep 14, 2022
There was a problem hiding this comment.
Let's discuss offline a couple of things:
- Shall we deprecate the old API in favor of this one?
- Shall we use the same pattern as for other APIs (i.e. not using
CallerArgumentExpressionAttribute) and do the update globally in v3? Or shall we add new principle directly now knowing we would have 2 kinds of API (inconsistent behavior for users).
Evangelink
reviewed
Sep 14, 2022
test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.IsInstanceOfTypeTests.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Evangelink
reviewed
Sep 15, 2022
|
Please update the description to mention the ticket this PR relates to. |
Evangelink
previously approved these changes
Sep 15, 2022
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
Evangelink
approved these changes
Sep 15, 2022
Haplois
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #413