Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid conditionals inside assertions #2751

Closed
Evangelink opened this issue Apr 24, 2024 · 1 comment · Fixed by #2848
Closed

Avoid conditionals inside assertions #2751

Evangelink opened this issue Apr 24, 2024 · 1 comment · Fixed by #2848
Assignees
@fhnaseer
Labels
Area: Analyzers sprint Type: Feature
Milestone
3.5.0

Comments

@Evangelink
Copy link
Member

Evangelink commented Apr 24, 2024 •
edited by pavelhorak

Category: Design
Default severity: Info
Enabled by default: true

Use cases: The rule should trigger a diagnostic when a conditional is used inside some assertion (e.g. Assert.AreEqual(a?.B, "ok")) and should recommend to split the call into 2 assertions (e.g. Assert.IsNotNull(a) and then Assert.AreEqual(a.B, "ok")).

AB#2051848
@Evangelink Evangelink added this to the 3.5.0 milestone Apr 24, 2024
@Evangelink Evangelink mentioned this issue Apr 24, 2024
Open
@fhnaseer fhnaseer self-assigned this May 6, 2024
@fhnaseer fhnaseer added the sprint label May 6, 2024
@testplatform-bot
Copy link
Contributor

✅ Successfully linked to Azure Boards work item(s):

@fhnaseer fhnaseer mentioned this issue May 15, 2024
Merged
This was referenced May 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhnaseer fhnaseer

Labels
Area: Analyzers sprint Type: Feature
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Avoid conditionals inside assertions analyzer microsoft/testfx
3 participants
@fhnaseer @Evangelink @testplatform-bot