Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential github action smells #6041

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ceddy4395
Copy link

Motivation and Context

Description

Hey! 🙂
I want to contribute the following changes to your workflow:

  • Use commit hash instead of tags for action versions
  • Use fixed version for runs-on argument
  • Avoid jobs without timeouts
  • Prevent running issue/PR actions on forks
  • Steps should only perform a single command
  • Use names for run steps

These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more

Contribution Checklist

- Use commit hash instead of tags for action versions
- Use fixed version for runs-on argument
- Avoid jobs without timeouts
- Prevent running issue/PR actions on forks
- Steps should only perform a single command
- Use names for run steps
- Avoid uploading artifacts on forks
@ceddy4395
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Member

@RogerBarreto RogerBarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point a reference why using the SHA instead of Major version is a smell?

Actually not being specific gives us the flexibility to be updated from patches and bugs found during a major version.

Similar questions were raised in this Repo with no detail.

dbeaver/dbeaver#29273

@ceddy4395
Copy link
Author

@RogerBarreto Here is a scientific paper and a blog post about potential security risks related to GitHub Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants