Lock node-fetch to avoid breaking change in 2.6.3 version #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
apostolisms,
D4N14L,
halfnibble,
iclanton,
octogonz and
sachinjoseph
as code owners
sachinjoseph
approved these changes
Sep 21, 2021
dmichon-msft
changed the title
|
Should an associated issue be filed with the owners of node-fetch? |
D4N14L
approved these changes
Sep 21, 2021
|
Very sorry about this, this is fixed in version |
apostolisms
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Version 2.6.3 of
node-fetchmade a breaking change to the encoding state of URLs that is incompatible with the expectations of@azure/core-httpwith regards to including SAS tokens in URLs. This locks the version used by Rush to 2.6.2 to avoid breaking customers who use the Azure cloud cache provider.How it was tested
Verified locally that installing with node-fetch 2.6.2 does not reproduce the authentication error encountered during cloud cache writes. Fresh installs started failing ~7 hours ago, which lines up with when version 2.6.3 of node-fetch was released.