Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #1920

Closed
wants to merge 1 commit into from
Closed

Update package.json #1920

wants to merge 1 commit into from

Conversation

liulinboyi
Copy link

update package source-map's version to resolve some question.
eg: when the version of source-map is ~0.6.1,the source-map.d.ts is not absolutely right.

@ghost
Copy link

ghost commented Jun 7, 2020

CLA assistant check
All CLA requirements met.

@octogonz
Copy link
Collaborator

octogonz commented Jun 7, 2020

We've been using 0.6.1 because, when the source-map library was rewritten to use the Rust programming language via WebAssembly, their API became asynchronous. Details here: mozilla/source-map#331 (comment) API Extractor's core algorithms are synchronous (which makes them easier to debug), so it seemed awkward to convert to async merely to support one library.

@liulinboyi Could you give some background about the problem you encountered, and why you abandoned your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants