Merge pull request #3108 from D4N14L/user/danade/ReenableEslintPlugin…

…Promise [eslint-config] Re-enable 'eslint-plugin-promise' rules
microsoft · Dec 25, 2021 · e357802 · e357802
2 parents 919fa13 + d53019b
commit e357802
Show file tree

Hide file tree

Showing 6 changed files with 43 additions and 13 deletions.
diff --git a/build-tests/install-test-workspace/workspace/common/pnpm-lock.yaml b/build-tests/install-test-workspace/workspace/common/pnpm-lock.yaml
diff --git a/...es/@rushstack/eslint-config/user-danade-ReenableEslintPluginPromise_2021-12-22-02-33.json b/...es/@rushstack/eslint-config/user-danade-ReenableEslintPluginPromise_2021-12-22-02-33.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/eslint-config",
+      "comment": "Re-enable eslint-plugin-promise rules which now support ESLint v8",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/eslint-config"
+}
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/common/config/rush/repo-state.json b/common/config/rush/repo-state.json
@@ -1,5 +1,5 @@
 // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
 {
-  "pnpmShrinkwrapHash": "8f53532ad47748ac29025ff560e44472e10ea2e7",
+  "pnpmShrinkwrapHash": "47aca98c44b4e322021c9f4f7f8bba4ddd58a905",
   "preferredVersionsHash": "87aab8e8f0a6545cb9d0ea30194ba68279d285a8"
 }
diff --git a/eslint/eslint-config/package.json b/eslint/eslint-config/package.json
@@ -34,6 +34,7 @@
     "@typescript-eslint/experimental-utils": "~5.6.0",
     "@typescript-eslint/parser": "~5.6.0",
     "@typescript-eslint/typescript-estree": "~5.6.0",
+    "eslint-plugin-promise": "~6.0.0",
     "eslint-plugin-react": "~7.27.1",
     "eslint-plugin-tsdoc": "~0.2.14"
   },

diff --git a/eslint/eslint-config/profile/_common.js b/eslint/eslint-config/profile/_common.js
@@ -42,10 +42,9 @@ function buildRules(profile) {
       // Plugin documentation: https://www.npmjs.com/package/@rushstack/eslint-plugin-security
       '@rushstack/eslint-plugin-security',
       // Plugin documentation: https://www.npmjs.com/package/@typescript-eslint/eslint-plugin
-      '@typescript-eslint/eslint-plugin'
+      '@typescript-eslint/eslint-plugin',
       // Plugin documentation: https://www.npmjs.com/package/eslint-plugin-promise
-      // TODO: Re-enable once updated to support eslint v8: https://github.com/xjamundx/eslint-plugin-promise/issues/218
-      // 'eslint-plugin-promise'
+      'eslint-plugin-promise'
     ],
 
     // Manually authored .d.ts files are generally used to describe external APIs that are  not expected
@@ -761,8 +760,7 @@ function buildRules(profile) {
           'prefer-const': 'warn',
 
           // RATIONALE:         Catches a common coding mistake where "resolve" and "reject" are confused.
-          // TODO: Re-enable once updated to support eslint v8: https://github.com/xjamundx/eslint-plugin-promise/issues/218
-          // 'promise/param-names': 'error',
+          'promise/param-names': 'error',
 
           // RATIONALE:         Catches code that is likely to be incorrect
           // STANDARDIZED BY:   eslint\conf\eslint-recommended.js