feat(react-native-test-app-msal): add support for Android #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
force-pushed
the
tido/msal-android
branch
from
e6aeae8
to
ff1caeb
Compare
- ignore user cancel error - pass authority - removed unused IAccountsHandler - improve error message handling - fix account selection
tido64
force-pushed
the
tido/msal-android
branch
from
ec46da0
to
e5ee4ed
Compare
github-actions
bot
added
the
chore
sweggersen
reviewed
Dec 7, 2021
|
|
||
| val userPrincipalName = sharedPreferences.getString(USERNAME_KEY, null) | ||
| val accountType = sharedPreferences.getString(ACCOUNT_TYPE_KEY, null) | ||
| val selectedAccount = allAccounts.find { |
There was a problem hiding this comment.
Could you have used your previously declared extension: fun List.find(userPrincipalName: String, accountType: AccountType)?
There was a problem hiding this comment.
That's for finding com.microsoft.identity.client.IAccount instances. We have our own Account type to abstract away this detail.
...ct-native-test-app-msal/android/src/main/java/com/microsoft/reacttestapp/msal/TokenBroker.kt
Outdated
Show resolved
Hide resolved
sweggersen
approved these changes
Dec 7, 2021
sveinar
reviewed
Dec 7, 2021
| + "react-native-test-app-msal": { | ||
| + "clientId": "00000000-0000-0000-0000-000000000000", | ||
| + "clientId": "4b0db8c2-9f26-4417-8bde-3f0e3656f8e0", |
There was a problem hiding this comment.
Yup, just reusing the id from the tutorials on https://github.com/AzureAD/microsoft-authentication-library-for-android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Android support to react-native-test-app-msal.
Remaining work
In order to enable the broker, we need the ability to configure the keystore in react-native-test-appTest plan