[0.63] Allow propagating WinRTWebSocketResource constructor exceptions #7898
Conversation
…osoft#7892) * Correctly format message on hresult_error * Remove noexcept from public constructors
JunielKatarn
added
the
AutoMerge
|
Hello @JunielKatarn! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
| WinRTWebSocketResource::WinRTWebSocketResource( | ||
| IMessageWebSocket &&socket, | ||
| IDataWriter &&writer, | ||
| Uri &&uri, | ||
| vector<ChainValidationResult> &&certExeptions) noexcept |
There was a problem hiding this comment.
2 reported at least:
- Malformed
Uri(i.e.Uri{""}) - Plain websocket instantiation failure (unknown cause):
MessageWebSocket{}
There was a problem hiding this comment.
Maybe worth adding a comment that such exception types could be thrown, so that consumers are at least aware?
There was a problem hiding this comment.
I wish the WinRT docs did that in the first place 😅
This should not be necessary because after this fix the exception will propagate to the JS layer and can be handled gracefully.
While 2.'s causes are still unclear, 1. is actually very expected if a malformed URI is passed to a component meant to establish a connection.
JunielKatarn
removed
the
AutoMerge
|
Awaiting unrelated fix #7918. |
JunielKatarn
added
the
AutoMerge
ghost
merged commit 
Backport of #7892.
Microsoft Reviewers: Open in CodeFlow