Skip to content

Commit

Permalink
[0.63] 3 Hacks to fix breaking changes from nuget affecting 0.63 pipe…
Browse files Browse the repository at this point in the history
…lines (#7918)

* Try to work around new nuget braking change

* Change files
  • Loading branch information
dannyvv committed Jun 2, 2021
1 parent 29eca7d commit bc22bbc
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 9 deletions.
1 change: 1 addition & 0 deletions .ado/variables/vs2019.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ variables:
runCodesignValidationInjection: false
NUGET_PLUGIN_HANDSHAKE_TIMEOUT_IN_SECONDS: 60
NUGET_PLUGIN_REQUEST_TIMEOUT_IN_SECONDS: 60
MSBUILDLOGPROPERTIESANDITEMSAFTEREVALUATION: false
8 changes: 0 additions & 8 deletions .ado/windows-vs-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -320,14 +320,6 @@ jobs:

- template: templates/prepare-env.yml

- task: NuGetCommand@2
displayName: NuGet restore - SampleApps
inputs:
command: restore
restoreSolution: packages/microsoft-reactnative-sampleapps/windows/SampleApps.sln
verbosityRestore: Detailed # Options: quiet, normal, detailed
condition: succeeded()

- task: CmdLine@2
displayName: run-windows (Debug)
inputs:
Expand Down
2 changes: 2 additions & 0 deletions Directory.Build.rsp
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/restore
/p:RestorePackagesConfig=true
8 changes: 8 additions & 0 deletions change/react-native-windows-2021-06-01-21-05-37-main.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "Try to work around new nuget braking change",
"packageName": "react-native-windows",
"email": "dannyvv@microsoft.com",
"dependentChangeType": "patch",
"date": "2021-06-02T04:05:37.421Z"
}
2 changes: 1 addition & 1 deletion vnext/PropertySheets/Autolink.props
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<RunAutolinkCheck Condition="'$(RunAutolinkCheck)' == ''">true</RunAutolinkCheck>
<AutolinkCommand Condition="'$(AutolinkCommand)' == ''">npx react-native autolink-windows</AutolinkCommand>
<AutolinkCommandWorkingDir Condition="'$(AutolinkCommandWorkingDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(ProjectDir), 'package.json'))</AutolinkCommandWorkingDir>
<AutolinkCommandArgs Condition="'$(AutolinkCommandArgs)' == '' And '$(SolutionPath)' != '' And '$(ProjectPath)' != ''">--check --sln $([MSBuild]::MakeRelative($(AutolinkCommandWorkingDir), $(SolutionPath))) --proj $([MSBuild]::MakeRelative($(AutolinkCommandWorkingDir), $(ProjectPath)))</AutolinkCommandArgs>
<AutolinkCommandArgs Condition="'$(AutolinkCommandArgs)' == '' And '$(SolutionPath)' != '' And '$(SolutionPath)' != '*Undefined*' And '$(ProjectPath)' != ''">--check --sln $([MSBuild]::MakeRelative($(AutolinkCommandWorkingDir), $(SolutionPath))) --proj $([MSBuild]::MakeRelative($(AutolinkCommandWorkingDir), $(ProjectPath)))</AutolinkCommandArgs>
<AutolinkCommandArgs Condition="'$(AutolinkCommandArgs)' == ''">--check</AutolinkCommandArgs>
</PropertyGroup>

Expand Down

0 comments on commit bc22bbc

Please sign in to comment.