Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): declare support for react-native-macos 0.66 #712

Merged
merged 2 commits into from Jan 26, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 25, 2022

Description

Adds react-native-macos 0.66 to the support matrix.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

npm run set-react-version 0.66
yarn
cd example
rm -rf macos/Pods macos/Podfile.lock
pod install --project-directory=macos
yarn macos

Screenshots:

With JSC With Hermes
image image

@tido64
Copy link
Member Author

tido64 commented Jan 25, 2022

With Hermes enabled:

diff --git a/example/macos/Podfile b/example/macos/Podfile
index 2266ea3..44b1ec3 100644
--- a/example/macos/Podfile
+++ b/example/macos/Podfile
@@ -2,7 +2,7 @@ require_relative '../node_modules/react-native-test-app/macos/test_app'

 workspace 'Example.xcworkspace'

-use_test_app! :hermes_enabled => false do |target|
+use_test_app! :hermes_enabled => true do |target|
   target.tests do
     pod 'Example-Tests', :path => '..'
   end

I am now getting linker errors:

Undefined symbols for architecture x86_64:
  "folly::exception_ptr_get_type(std::exception_ptr const&)", referenced from:
      folly::exception_wrapper::ExceptionPtr::type_(folly::exception_wrapper const*) in libRCT-Folly.a(ExceptionWrapper.o)
      folly::exceptionStr(std::exception_ptr const&) in libRCT-Folly.a(ExceptionString.o)
  "folly::exception_ptr_get_object(std::exception_ptr const&, std::type_info const*)", referenced from:
      std::exception* folly::exception_ptr_get_object<std::exception>(std::exception_ptr const&) in libReact-hermes.a(Connection.o)
      std::exception* folly::exception_ptr_get_object<std::exception>(std::exception_ptr const&) in libRCT-Folly.a(ExceptionWrapper.o)
      std::exception* folly::exception_ptr_get_object<std::exception>(std::exception_ptr const&) in libRCT-Folly.a(ExceptionString.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Edit: Fixed upstream: microsoft/react-native-macos#982

@tido64 tido64 merged commit f2ee348 into trunk Jan 26, 2022
@tido64 tido64 deleted the tido/support-rnm-0.67 branch January 26, 2022 11:42
@tido64 tido64 added this to the 1.0 milestone Jan 26, 2022
@tido64 tido64 mentioned this pull request Jan 26, 2022
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants