Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix CI failing on bundle install #603

Merged
merged 6 commits into from Nov 22, 2021
Merged

ci: fix CI failing on bundle install #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d659504
ci: fix CI failing on `bundle install`
tido64 Nov 22, 2021
053443a
specify Gemlock.file?
tido64 Nov 22, 2021
80555b9
explicitly set working directory?
tido64 Nov 22, 2021
8c76a08
set up Ruby after checkout to find Gemfile
tido64 Nov 22, 2021
a21fb27
only scan checked in files
tido64 Nov 22, 2021
a447262
exclude gems install path
tido64 Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Expand Up @@ -53,6 +53,12 @@ jobs:
with:
path: .yarn/cache
key: ${{ hashFiles('yarn.lock') }}
- name: Set up Ruby
uses: ruby/setup-ruby@v1.86.0
with:
ruby-version: '3.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ruby-version: '3.0'
ruby-version: "3.0"

bundler: Gemfile.lock
bundler-cache: true
- name: Install
run: |
yarn
Expand All @@ -67,7 +73,6 @@ jobs:
scripts/clang-format-diff.sh || true
- name: CocoaPods
run: |
bundle install
echo "::add-matcher::.github/rubocop.json"
bundle exec rubocop
echo "::remove-matcher owner=rubocop::"
Expand Down
1 change: 1 addition & 0 deletions .rubocop.yml
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@ AllCops:
NewCops: enable
Exclude:
- "**/node_modules/**/*"
- "vendor/bundle/**/*"
TargetRubyVersion: 2.6

Layout/LineLength:
Expand Down
14 changes: 7 additions & 7 deletions Gemfile.lock
View file
Open in desktop
Expand Up @@ -4,35 +4,35 @@ GEM
GEM
remote: https://rubygems.org/
specs:
CFPropertyList (3.0.4)
CFPropertyList (3.0.5)
rexml
ast (2.4.2)
atomos (0.1.3)
claide (1.0.3)
colored2 (3.1.2)
minitest (5.14.4)
nanaimo (0.3.0)
parallel (1.20.1)
parallel (1.21.0)
parser (3.0.2.0)
ast (~> 2.4.1)
rainbow (3.0.0)
regexp_parser (2.1.1)
rexml (3.2.5)
rubocop (1.20.0)
rubocop (1.23.0)
parallel (~> 1.10)
parser (>= 3.0.0.0)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml
rubocop-ast (>= 1.9.1, < 2.0)
rubocop-ast (>= 1.12.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.11.0)
rubocop-ast (1.13.0)
parser (>= 3.0.1.1)
rubocop-minitest (0.15.0)
rubocop-minitest (0.16.0)
rubocop (>= 0.90, < 2.0)
ruby-progressbar (1.11.0)
unicode-display_width (2.0.0)
unicode-display_width (2.1.0)
xcodeproj (1.21.0)
CFPropertyList (>= 2.3.3, < 4.0)
atomos (~> 0.1.3)
Expand Down
2 changes: 1 addition & 1 deletion ios/test_app.rb
View file
Open in desktop
Expand Up @@ -231,7 +231,7 @@ def make_project!(xcodeproj, project_root, target_platform)

react_native = react_native_path(project_root, target_platform)
version = package_version(react_native.to_s).segments
version = version[0] * 10_000 + version[1] * 100 + version[2]
version = (version[0] * 10_000) + (version[1] * 100) + version[2]
version_macro = "REACT_NATIVE_VERSION=#{version}"

build_settings = {}
Expand Down