Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(apple): move manifest writing to build phase #2030

Merged
merged 1 commit into from
May 10, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented May 10, 2024

Description

Test output path of generated manifest files

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

n/a

@tido64 tido64 requested a review from kelset as a code owner May 10, 2024 08:43
@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS labels May 10, 2024
@tido64 tido64 marked this pull request as draft May 10, 2024 08:52
@tido64 tido64 force-pushed the tido/embed-manifest/tests branch from 51508a0 to 4de5433 Compare May 10, 2024 09:02
@tido64 tido64 changed the title test: test output path of generated manifest files refactor(apple): move manifest writing to build phase May 10, 2024
@github-actions github-actions bot added platform: Android This affects Android platform: Windows This affects Windows labels May 10, 2024
@tido64 tido64 marked this pull request as ready for review May 10, 2024 09:04
@tido64 tido64 requested a review from Saadnajmi as a code owner May 10, 2024 09:04
@tido64 tido64 merged commit 9535916 into trunk May 10, 2024
30 checks passed
@tido64 tido64 deleted the tido/embed-manifest/tests branch May 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS platform: Windows This affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants