Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up TypeScript errors when module: node16 #2028

Merged
merged 1 commit into from
May 8, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented May 8, 2024

Description

Clean up TypeScript errors when module: node16

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

Change both module and moduleResolution to Node16 (or simply remove them since that's what @rnx-kit/tsconfig/tsconfig.esm.json defaults to):

diff --git a/tsconfig.esm.json b/tsconfig.esm.json
index b229154..d8132f3 100644
--- a/tsconfig.esm.json
+++ b/tsconfig.esm.json
@@ -1,8 +1,8 @@
 {
   "extends": "@rnx-kit/tsconfig/tsconfig.esm.json",
   "compilerOptions": {
-    "module": "ES2022",
-    "moduleResolution": "Node",
+    "module": "Node16",
+    "moduleResolution": "Node16",
     "noEmit": true
   },
   "include": [

Run yarn lint:js. There will be some errors left, most notable related to ajv, cliui, mustache, and webdriverio. I will fix them separately if I get around to investigating the root cause.

@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows platform: visionOS labels May 8, 2024
@tido64 tido64 enabled auto-merge (squash) May 8, 2024 13:08
@tido64 tido64 merged commit f9467ac into trunk May 8, 2024
30 checks passed
@tido64 tido64 deleted the tido/typescript-fixes branch May 8, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS platform: Windows This affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants