Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate schema.js to ESM #1988

Merged
merged 1 commit into from Apr 29, 2024
Merged

chore: migrate schema.js to ESM #1988

merged 1 commit into from Apr 29, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 23, 2024

Description

Migrate schema.js to ESM

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

n/a

Base automatically changed from tido/embed-manifest-swift to trunk April 29, 2024 10:54
@tido64 tido64 marked this pull request as ready for review April 29, 2024 10:55
@tido64 tido64 requested a review from kelset as a code owner April 29, 2024 10:55
kelset
kelset approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@tido64 tido64 merged commit 064fee4 into trunk Apr 29, 2024
30 checks passed
@tido64 tido64 deleted the tido/refactor-schema branch April 29, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tido64 @kelset