Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): fix build break introduced in 2.5.13 #1527

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Aug 1, 2023

Description

Fix build break introduced in #1522

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

Enable single app mode:

diff --git a/example/app.json b/example/app.json
index ef69fa7..8e4ddc7 100644
--- a/example/app.json
+++ b/example/app.json
@@ -2,10 +2,12 @@
   "$schema": "https://raw.githubusercontent.com/microsoft/react-native-test-app/trunk/schema.json",
   "name": "Example",
   "displayName": "Example",
+  "singleApp": "example-app",
   "components": [
     {
       "appKey": "Example",
-      "displayName": "App"
+      "displayName": "App",
+      "slug": "example-app"
     },
     {
       "appKey": "Example",

Build and run:

pod install --project-directory=macos
yarn macos

In a separate terminal, start the dev server:

yarn start

@tido64 tido64 merged commit 2a626dd into trunk Aug 2, 2023
27 checks passed
@tido64 tido64 deleted the tido/fix-macos-regression branch August 2, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: macOS This affects macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants