Fix ImageView tint color

[shwanton]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary:

ImageView tint color was broken after this change on core:
facebook@ce7c0b7
This change was from 2015 😅!

Paper should use the RCTUIImageView class for rendering which has the same tintColor property as the iOS UIImageView class.

Changelog:

[MACOS] [FIXED] - Fix ImageView tint color

Test Plan:

RN Tester

[shwanton]

fixes #1948

[shwanton]

NSImageView has a contentTintColor which should set the template tint correctly.

#1843 Added a change for Fabric does affect Paper since the RCTImageView has an internal RCTUIImageViewAnimated which is a RCTUIImageView
https://github.com/microsoft/react-native-macos/blame/main/packages/react-native/Libraries/Image/RCTUIImageViewAnimated.h#L11

This change requires us to use tintColor for tinting to work correctly.

[amgleitman]

/azp run

[Saadnajmi]

Did some digging/testing and learned this:

• tintColor is an iOS UIView property, not a UIImageView property
• contentTintColor is not a macOS NSView property.. it's an NSButton property
• We custom implemented RCTUIImageView.tintColor with a custom CALayer tintingLayer
• As such, if we wanted to implement tintColor all up in our shim, we should probably move the whole tintingLayer implementation from RCTUIImageView to RCTUIView

That sounds out of scope, so approving this PR for now ⁠:D

[Saadnajmi]

Did some digging/testing and learned this:

• tintColor is an iOS UIView property, not a UIImageView property
• contentTintColor is not a macOS NSView property.. it's an NSButton property
• We custom implemented RCTUIImageView.tintColor with a custom CALayer tintingLayer
• As such, if we wanted to implement tintColor all up in our shim, we should probably move the whole tintingLayer implementation from RCTUIImageView to RCTUIView

That sounds out of scope, so approving this PR for now ⁠:D

Actually wait. contentTintColor is also an NSImageView property and should work but doesn't... so I don't know.