-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ImageView tint color #1996
Fix ImageView tint color #1996
Conversation
fixes #1948 |
NSImageView has a #1843 Added a change for Fabric does affect Paper since the This change requires us to use |
/azp run |
Did some digging/testing and learned this:
That sounds out of scope, so approving this PR for now :D |
Actually wait. |
Please select one of the following
Summary:
ImageView tint color was broken after this change on core:facebook@ce7c0b7
This change was from 2015 😅!
Paper should use the RCTUIImageView class for rendering which has the same tintColor property as the iOS UIImageView class.
Changelog:
[MACOS] [FIXED] - Fix ImageView tint color
Test Plan:
RN Tester
![CleanShot 2023-12-15 at 17 13 12@2x](https://private-user-images.githubusercontent.com/96719/290963843-edf814bc-19e5-4489-ae55-059bead5c3de.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTY5OTM3OTIsIm5iZiI6MTcxNjk5MzQ5MiwicGF0aCI6Ii85NjcxOS8yOTA5NjM4NDMtZWRmODE0YmMtMTllNS00NDg5LWFlNTUtMDU5YmVhZDVjM2RlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTI5VDE0MzgxMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQxMzdiYmFlNTViNzY1YzM0ZGI5OTk3MjRmMjZhNmEzYjk0MDUyODE1ODA5NTQxZDhmYzYwOWZjMWM4NTc4MzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.--AJbHTb9GsXhW6AQPpsKajXLsrYvnjREn1nbgyhMwM)