Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add explainer for gotchas with NSView based native components #1904

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

While working on microsoft/fluentui-react-native#3026, I found a couple of "gotchas" while writing a native component for NSVisualEffectView. This change attempts to documents those gotchas so that others can benefit. Special thanks to @lenaic who figured out the hit testing issue.

Changelog

[GENERAL] [ADDED] - Add documentation for gotchas with NSView based native components

Test Plan

N/A

@Saadnajmi Saadnajmi requested a review from a team as a code owner August 11, 2023 07:00
@Saadnajmi Saadnajmi marked this pull request as draft August 14, 2023 17:19
@Saadnajmi
Copy link
Collaborator Author

Marking as draft to see if I can update RCTUIView hitTest instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant