Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fabric] Point scale factor update support #1844

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Fabric] Point scale factor update support #1844

wants to merge 2 commits into from

Commits on Jun 8, 2023

  1. Commit cloned shadow node tree on pointScaleFactor change.

    Nick committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    9372f4e View commit details
    Browse the repository at this point in the history

  2. Force Yoga to assign the new layout metrics to the shadow node by mar… 

    …king the full tree dirty.

Without this the setHasNewLayout function won't be called, which makes the differ not detect a change because the updated layout metrics were not assigned to the LayoutableShadowNode.
    Nick committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    13703d0 View commit details
    Browse the repository at this point in the history