Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick #1004 into 0.66-stable #1013

Merged
merged 2 commits into from Feb 8, 2022
+2 −12
Merged

Cherry pick #1004 into 0.66-stable #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
504349e
Remove duplicate RCTDevSettingsInspectable
amgleitman Feb 3, 2022
e9cc8e8
Mark new RCTEventEmitter properties as nullable
amgleitman Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 0 additions & 10 deletions React/CoreModules/RCTDevSettings.h
View file
Open in desktop
Expand Up @@ -48,16 +48,6 @@

@end

@protocol RCTDevSettingsInspectable <NSObject>

/**
* Whether current jsi::Runtime is inspectable.
* Only set when using as a bridgeless turbo module.
*/
@property (nonatomic, assign, readwrite) BOOL isInspectable;

@end

@interface RCTDevSettings : RCTEventEmitter <RCTInitializing>

- (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource;
Expand Down
4 changes: 2 additions & 2 deletions React/Modules/RCTEventEmitter.h
View file
Open in desktop
Expand Up @@ -14,8 +14,8 @@
@interface RCTEventEmitter : NSObject <RCTBridgeModule, RCTInvalidating>

@property (nonatomic, weak) RCTBridge * _Nullable bridge; // TODO(macOS GH#774)
@property (nonatomic, weak) RCTModuleRegistry *moduleRegistry;
@property (nonatomic, weak) RCTViewRegistry *viewRegistry_DEPRECATED;
@property (nonatomic, weak) RCTModuleRegistry * _Nullable moduleRegistry; // TODO(macOS GH#774)
@property (nonatomic, weak) RCTViewRegistry * _Nullable viewRegistry_DEPRECATED; // TODO(macOS GH#774)

- (instancetype _Nullable)initWithDisabledObservation; // TODO(macOS GH#774)

Expand Down