Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug that results in a false negative when determining if a call… #7938

Merged
merged 1 commit into from
May 17, 2024

Conversation

erictraut
Copy link
Collaborator

…able type is compatible with another callable type and the first has a *args parameter and the second has a single positional+keyword parameter. This addresses #7937.

…able type is compatible with another callable type and the first has a `*args` parameter and the second has a single positional+keyword parameter. This addresses #7937.
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

antidote (https://github.com/Finistere/antidote)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+       Keyword parameter "self" is missing in source
-       Position-only parameter mismatch; parameter "self" is not position-only
+         Position-only parameter mismatch; parameter "self" is not position-only
-       Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)
+         Position-only parameter mismatch; expected 1 but received 0 (reportInconsistentOverload)

@erictraut erictraut merged commit 7699780 into main May 17, 2024
12 checks passed
@erictraut erictraut deleted the issue7937 branch May 17, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant