Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test to check fro PF eval dependencies on private API's #3135

Merged
merged 12 commits into from May 9, 2024

Conversation

singankit
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented May 7, 2024

promptflow SDK CLI Azure E2E Test Result users/singankit/pf_eval_deps

  4 files    4 suites   4m 7s ⏱️
241 tests 205 ✅  36 💤 0 ❌
964 runs  820 ✅ 144 💤 0 ❌

Results for commit 15206d0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 7, 2024

SDK CLI Global Config Test Result users/singankit/pf_eval_deps

6 tests   6 ✅  1m 11s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 15206d0.

♻️ This comment has been updated with latest results.

nick863
nick863 previously approved these changes May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Executor Unit Test Result users/singankit/pf_eval_deps

792 tests   792 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 15206d0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 7, 2024

Executor E2E Test Result users/singankit/pf_eval_deps

242 tests   234 ✅  5m 12s ⏱️
  1 suites    5 💤
  1 files      3 ❌

For more details on these failures, see this check.

Results for commit 15206d0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 7, 2024

SDK CLI Test Result users/singankit/pf_eval_deps

    4 files      4 suites   1h 1m 47s ⏱️
  684 tests   646 ✅  38 💤 0 ❌
2 736 runs  2 584 ✅ 152 💤 0 ❌

Results for commit 15206d0.

♻️ This comment has been updated with latest results.

@singankit singankit merged commit 0690f41 into main May 9, 2024
39 of 41 checks passed
@singankit singankit deleted the users/singankit/pf_eval_deps branch May 9, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants