Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Synchronize read and writes to avoid race condition reading babel transpiled files from local disk cache #30578

Closed
wants to merge 3 commits into from

Conversation

sunilsurana
Copy link
Member

@sunilsurana sunilsurana commented Apr 27, 2024

  1. Add a maker file to check if the previous write was fully completed.
  2. In writefilesync section change the write mode to wx which uses exclusive lock
  3. If two writes happen same time and we get EEXIST error then ignore that
    FIX for [Bug]: Parallel test process execution causing race condition and empty babel transpiled file read from disk cache #30577

…nspiled files from disk cache

First add a maker file to check if the previous write was fully completed. Then again in writefile section change the write mode to wx which uses exclusive lock and if two writes happen same time and we get EEXist error then ignore that
FIX for microsoft#30577
…nspiled files from disk cache

First add a maker file to check if the previous write was fully completed. Then again in writefile section change the write mode to wx which uses exclusive lock and if two writes happen same time and we get EEXist error then ignore that
FIX for microsoft#30577

This comment has been minimized.

This comment has been minimized.

@sunilsurana sunilsurana changed the title fix : Synchronize read and writes to avoid race condition reading tranpiled files from git cache fix : Synchronize read and writes to avoid race condition reading babel transpiled files from git cache Apr 27, 2024
@sunilsurana sunilsurana changed the title fix : Synchronize read and writes to avoid race condition reading babel transpiled files from git cache fix : Synchronize read and writes to avoid race condition reading babel transpiled files from local disk cache Apr 29, 2024
Copy link
Contributor

Test results for "tests 1"

1 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:240:1 › should have network requests

27248 passed, 671 skipped
✔️✔️✔️

Merge workflow run.

@dgozman
Copy link
Contributor

dgozman commented May 2, 2024

Closing for now, see the linked issue.

@dgozman dgozman closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants