Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support import components from node_modules #30458

Closed
wants to merge 2 commits into from

Conversation

tanhauhau
Copy link
Contributor

No description provided.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

8 failed
❌ [playwright-test] › playwright.ct-react.spec.ts:549:5 › should allow import from node modules
❌ [playwright-test] › playwright.spec.ts:248:5 › should respect headless in launchPersistent
❌ [playwright-test] › playwright.ct-react.spec.ts:549:5 › should allow import from node modules
❌ [playwright-test] › playwright.spec.ts:248:5 › should respect headless in launchPersistent
❌ [playwright-test] › playwright.ct-react.spec.ts:549:5 › should allow import from node modules
❌ [playwright-test] › playwright.spec.ts:141:5 › should not override use:browserName without projects
❌ [playwright-test] › playwright.ct-react.spec.ts:549:5 › should allow import from node modules
❌ [playwright-test] › playwright.ct-react.spec.ts:549:5 › should allow import from node modules

1 flaky ⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name

27404 passed, 672 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This has already been fixed by #30493 in the same way, so I'll have to close it. Next time, please attribute a PR to an issue it is fixing by adding Fixes #29854 to the description.

@dgozman dgozman closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants