test: add getByRole tests for all roles
#30267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"6 fatal errors, not part of any test 2 flaky6214 passed, 55 skipped Merge workflow run. |
|
@microsoft-github-policy-service agree |
billfienberg
changed the title
getByRole tests for all roles
|
@billfienberg Thank you for the PR! Unfortunately, most likely we would not merge it. We'd prefer PRs that identify the expected behavior based on the real-life examples rather than unit tests that just document the existing behavior. Ideally, there would be an improvement that fixes an issue and includes relevant test cases. If you are willing to contribute in this space, I'd recommend to first collaborate on the issue to identify the usecases and possible improvements. Let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
This PR adds
getByRoletests for every aria role, and annotates the the failing roles with thefixmeannotation.Related Issues