Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): allow running codegen with selected browser/options #29454

Closed
wants to merge 1 commit into from

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt marked this pull request as draft February 12, 2024 12:04

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@mxschmitt mxschmitt marked this pull request as ready for review March 19, 2024 20:20

This comment has been minimized.

@@ -70,7 +81,28 @@ export class Runner {
report.projects.push({
name: project.project.name,
testDir: project.project.testDir,
use: { testIdAttribute: project.project.use.testIdAttribute },
use: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should send this information back and forth, it looks like this should rather be a part of the test server.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

20 failed
❌ [chromium-library] › library/debug-controller.spec.ts:241:1 › should record with a new browser if triggered with different browserName
❌ [chromium-library] › library/debug-controller.spec.ts:241:1 › should record with a new browser if triggered with different browserName
❌ [chromium-library] › library/debug-controller.spec.ts:241:1 › should record with a new browser if triggered with different browserName
❌ [firefox-library] › library/debug-controller.spec.ts:70:1 › should pick element
❌ [firefox-library] › library/debug-controller.spec.ts:163:1 › should record
❌ [firefox-library] › library/debug-controller.spec.ts:198:1 › should record with the same browser if triggered with the same options
❌ [firefox-library] › library/debug-controller.spec.ts:359:1 › should record custom data-testid
❌ [playwright-test] › ui-mode-trace.spec.ts:76:5 › should merge screenshot assertions
❌ [chromium-library] › library/debug-controller.spec.ts:70:1 › should pick element
❌ [chromium-library] › library/debug-controller.spec.ts:163:1 › should record
❌ [chromium-library] › library/debug-controller.spec.ts:198:1 › should record with the same browser if triggered with the same options
❌ [chromium-library] › library/debug-controller.spec.ts:241:1 › should record with a new browser if triggered with different browserName
❌ [chromium-library] › library/debug-controller.spec.ts:305:1 › should record with same browser but re-applied context options if triggered with different contextOptions
❌ [chromium-library] › library/debug-controller.spec.ts:359:1 › should record custom data-testid
❌ [playwright-test] › ui-mode-trace.spec.ts:76:5 › should merge screenshot assertions
❌ [webkit-library] › library/debug-controller.spec.ts:70:1 › should pick element
❌ [webkit-library] › library/debug-controller.spec.ts:163:1 › should record
❌ [webkit-library] › library/debug-controller.spec.ts:198:1 › should record with the same browser if triggered with the same options
❌ [webkit-library] › library/debug-controller.spec.ts:241:1 › should record with a new browser if triggered with different browserName
❌ [webkit-library] › library/debug-controller.spec.ts:359:1 › should record custom data-testid

4 flaky ⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:93:5 › should run component tests after editing component
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:184:5 › should watch new file
⚠️ [webkit-library] › library/browsercontext-device.spec.ts:45:5 › device › should scroll to click
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline

26865 passed, 621 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants