Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): make sure user arguments go first #29204

Merged
merged 2 commits into from Jan 29, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jan 27, 2024

Previously --no-sandbox param could creep in before the args.

Fixes #29198

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

21377 passed, 581 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit ad6e405 into microsoft:main Jan 29, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REGRESSION]: client-provided arguments to electron is at the end of argv list
2 participants