fix(routes): catch route handlers upon respective page closure #23929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, route handler can throw when page is closed in the middle of it's execution, especially with `route.fetch()` call inside. Since you cannot really control when the route hanlder is called, it is hard to handle this situation. However, Playwright can just ignore exceptions in routes after page closure. This would eliminate any potential issues with using Playwright APIs from the route handler. There is a small chance of unrelated exception being unnoticed in the ignored route handlers, but that seems like small price.
|
"tests 1" report. |
mxschmitt
approved these changes
Jun 27, 2023
| @@ -513,7 +514,12 @@ export class Page extends ChannelOwner<channels.PageChannel> implements api.Page | |||
| await this._channel.bringToFront(); | |||
| } | |||
|
|
|||
| _shouldCatchAllRouteHandlers() { | |||
There was a problem hiding this comment.
Suggested change
| _shouldCatchAllRouteHandlers() { | |
| _shouldIgnoreAllRouteHandlerExceptions() { |
nit: I find catch without context not that meaningful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, route handler can throw when page is closed in the middle of it's execution, especially with
route.fetch()call inside.Since you cannot really control when the route hanlder is called, it is hard to handle this situation. However, Playwright can just ignore exceptions in routes after page closure. This would eliminate any potential issues with using Playwright APIs from the route handler.
There is a small chance of unrelated exception being unnoticed in the ignored route handlers, but that seems like small price.
Fixes #23781.