Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ct): initial angular #19395

Closed
wants to merge 1 commit into from
Closed

Conversation

sand4rt
Copy link
Collaborator

@sand4rt sand4rt commented Dec 10, 2022

related to: #14153, #19380.

Includes a simple base project that is consistent with the other frameworks and added a mount + unmount for standalone components (no transpilation yet). @yjaaidi Perhaps you can build upon this?

@pavelfeldman
Copy link
Member

@yjaaidi how do you feel about this change? I'd like to make sure that the credit goes where it is due as angular support gets merged upstream!

@sand4rt
Copy link
Collaborator Author

sand4rt commented Dec 20, 2022

It's also fine if you want to close this and put it under your name

@yjaaidi
Copy link

yjaaidi commented Dec 28, 2022

Thanks @pavelfeldman & @sand4rt for caring about the credit. Thx @sand4rt for putting this together.
Sorry for the delay but I should be able to have a closer look by next week.

Also, @pavelfeldman, where can we discuss the vision and roadmap of Playwright CT in general? Twitter DM? A public discussion on GitHub?

@pavelfeldman
Copy link
Member

https://discord.gg/RpJD7uKM - you can ping me on Discord.

@sand4rt
Copy link
Collaborator Author

sand4rt commented Feb 16, 2023

@pavelfeldman, @yjaaidi, @brandonroberts is there's any progress? if not, i could create a POC/proposal similar to the other frameworks including @brandonroberts's Vite plugin? Would be very interested in your feedback. @pavelfeldman if you want to wait it is also fine of course!

@sand4rt sand4rt force-pushed the ct-angular-initial branch 2 times, most recently from 9289f1d to 10dd99d Compare February 24, 2023 11:35
@pavelfeldman
Copy link
Member

Let me close this as stale since we did not get a clear go ahead signal from yjaaidi.

@sand4rt you can still contribute a clean room implementation of the support for angular. Make sure you keep the existing copyright headers if you are using third party code: BSD, MIT, Apache would all work.

@sand4rt
Copy link
Collaborator Author

sand4rt commented Feb 27, 2023

Alright, i'm continuing the work over here: https://github.com/sand4rt/playwright-ct-angular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants