Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: verify tab groups in docs during lint #18768

Merged
merged 1 commit into from Nov 14, 2022

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Nov 14, 2022

This extracts the logic from playwright.dev so that we get early warnings.

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of that I thought about instead triggering a docs roll+build if files in docs/ get changed.
Should not require much compute and not hurt much.

@dgozman
Copy link
Contributor Author

dgozman commented Nov 14, 2022

Instead of that I thought about instead triggering a docs roll+build if files in docs/ get changed. Should not require much compute and not hurt much.

I don't think this will work nicely on my local machine, but npm run doc just works.

@yury-s yury-s merged commit bc6617b into microsoft:main Nov 14, 2022
aslushnikov pushed a commit to aslushnikov/playwright that referenced this pull request Nov 16, 2022
… lint

This extracts the logic from playwright.dev so that we get early
warnings.
aslushnikov added a commit that referenced this pull request Nov 16, 2022
…8837)

This extracts the logic from playwright.dev so that we get early
warnings.

Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants