fix(driver): with CWD which contained spaces #17579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Sep 26, 2022
| @@ -1,4 +1,6 @@ | |||
| @ECHO OFF | |||
| SETLOCAL | |||
| IF %PLAYWRIGHT_NODEJS_PATH%x == x SET PLAYWRIGHT_NODEJS_PATH="%~dp0\node.exe" | |||
| "%PLAYWRIGHT_NODEJS_PATH%" "%~dp0\package\lib\cli\cli.js" %* | |||
| if not defined PLAYWRIGHT_NODEJS_PATH ( | |||
There was a problem hiding this comment.
nit: use all CAPITAL letters for the keywords?
There was a problem hiding this comment.
microsoft does use lowercase in the docs, so it seems better like that: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/if
rwoll
approved these changes
Sep 26, 2022
|
Let's consider cherry-picking over to 1.26 branch and releasing a python version with it. |
mxschmitt
pushed a commit
that referenced
this pull request
Sep 26, 2022
) This PR cherry-picks the following commits: - a5eee6d Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Oct 19, 2022
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did manual testing on my Windows machine to verify that it works in a folder with spaces. Also passing a custom Node.js path seemed to not have worked before.
Fixes microsoft/playwright-python#1561
Fixes microsoft/playwright-python#1565