Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION]: client-provided arguments to electron is at the end of argv list #29198

Closed
Maddobun opened this issue Jan 26, 2024 · 3 comments · Fixed by #29204
Closed

[REGRESSION]: client-provided arguments to electron is at the end of argv list #29198

Maddobun opened this issue Jan 26, 2024 · 3 comments · Fixed by #29204

Comments

@Maddobun
Copy link

Maddobun commented Jan 26, 2024

We used to have this PR #16782 which addresses this issue #16614.
It looks like this change was lost over the course of a few commits on the same file.

@yury-s
Copy link
Member

yury-s commented Jan 27, 2024

This regressed in #18804. We cannot directly pass user arguments first as playwright may use custom loader which goes as the first option and also expects certain options order, we ned to change that.

@yury-s
Copy link
Member

yury-s commented Jan 27, 2024

@Maddobun what arguments do you see before yours? Looking at the code, it seems that most of the time it should be just your custom args but sometimes on linux --no-sanbox could appear first, is that what you observe? Also which playwright version are you using?

@Maddobun
Copy link
Author

Maddobun commented Jan 27, 2024

@Maddobun what arguments do you see before yours? Looking at the code, it seems that most of the time it should be just your custom args but sometimes on linux --no-sanbox could appear first, is that what you observe? Also which playwright version are you using?

I'm on 1.41.1 and in process.argv of my own electron app I'm seeing both --inspect=0 and --remote-debugging-port=0 between the executable path and my provided args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants