fix: properly handle negated timed-out toPass matcher (#19580)

microsoft · Dec 20, 2022 · d7e7cab · d7e7cab
1 parent bb2a2c7
commit d7e7cab
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/packages/playwright-test/src/matchers/matchers.ts b/packages/playwright-test/src/matchers/matchers.ts
@@ -358,5 +358,5 @@ export async function toPass(
     `- ${timeoutMessage}`,
   ].join('\n') : timeoutMessage;
 
-  return { message, pass: false };
+  return { message, pass: isNot ? true : false };
 }
diff --git a/tests/playwright-test/expect-to-pass.spec.ts b/tests/playwright-test/expect-to-pass.spec.ts
@@ -166,4 +166,17 @@ test('should work with soft', async ({ runInlineTest }) => {
   expect(stripAnsi(result.output)).toContain('Received: 2');
   expect(result.exitCode).toBe(1);
   expect(result.failed).toBe(1);
-});
+});
+
+test('should not accept TimeoutError', async ({ runInlineTest }) => {
+  const result = await runInlineTest({
+    'a.spec.ts': `
+      const { test } = pwt;
+      test('should fail', async () => {
+        await test.expect(() => {}).not.toPass({ timeout: 1 });
+      });
+    `
+  });
+  expect(result.exitCode).toBe(1);
+  expect(result.failed).toBe(1);
+});