Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: Max Schmitt <max@schmitt.mx>
  • Loading branch information
mxschmitt committed Dec 19, 2022
1 parent 8724072 commit a1e0f0e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions docs/src/release-notes-csharp.md
Expand Up @@ -16,11 +16,11 @@ toc_max_heading_level: 2
var response = await route.FetchAsync();

// Force settings theme to a predefined value.
var json = await response.JsonAsync();
json["theme"] = "Solorized";
var json = await response.JsonAsync<MyDataType>();
json.Theme = "Solarized";

// Fulfill with modified data.
await route.FulfillAsync(new RouteFulfillOptions {
await route.FulfillAsync(new() {
Json = json
});
});
Expand All @@ -30,7 +30,7 @@ toc_max_heading_level: 2

```csharp
// Check all checkboxes!
var checkboxes = await Page.LocatorAsync("role=checkbox");
var checkboxes = Page.Locator("role=checkbox");
foreach (var checkbox in await checkboxes.AllAsync())
await checkbox.CheckAsync();
```
Expand Down
2 changes: 1 addition & 1 deletion docs/src/release-notes-java.md
Expand Up @@ -12,7 +12,7 @@ toc_max_heading_level: 2

```java
// Check all checkboxes!
const checkboxes = page.getByRole('checkbox');
Locator checkboxes = page.getByRole('checkbox');
for (Locator checkbox : checkboxes.all())
checkbox.check();
```
Expand Down

0 comments on commit a1e0f0e

Please sign in to comment.