Skip to content

Commit

Permalink
Revert "chore(driver): roll driver to recent Node.js LTS version (#18… (
Browse files Browse the repository at this point in the history
#18791)

…636)"

The new node resolves loalhost to ::1 by default which breaks API tests
in the ports (Java in particular). Reverting to the previous LTS to
allow some time to implement happy eyeballs algorithm on our end by next
release.

This reverts commit 63a0b75.
Reference #18790
  • Loading branch information
yury-s committed Nov 14, 2022
1 parent 1e309f3 commit 70065ba
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion utils/build/build-playwright-driver.sh
Expand Up @@ -4,7 +4,7 @@ set -x

trap "cd $(pwd -P)" EXIT
SCRIPT_PATH="$(cd "$(dirname "$0")" ; pwd -P)"
NODE_VERSION="18.12.1" # autogenerated via ./update-playwright-driver-version.mjs
NODE_VERSION="16.18.0" # autogenerated via ./update-playwright-driver-version.mjs

cd "$(dirname "$0")"
PACKAGE_VERSION=$(node -p "require('../../package.json').version")
Expand Down
4 changes: 2 additions & 2 deletions utils/docker/Dockerfile.focal
Expand Up @@ -7,9 +7,9 @@ ARG DOCKER_IMAGE_NAME_TEMPLATE="mcr.microsoft.com/playwright:v%version%-focal"
# === INSTALL Node.js ===

RUN apt-get update && \
# Install node18
# Install node16
apt-get install -y curl wget gpg && \
curl -sL https://deb.nodesource.com/setup_18.x | bash - && \
curl -sL https://deb.nodesource.com/setup_16.x | bash - && \
apt-get install -y nodejs && \
# Feature-parity with node.js base images.
apt-get install -y --no-install-recommends git openssh-client && \
Expand Down
4 changes: 2 additions & 2 deletions utils/docker/Dockerfile.jammy
Expand Up @@ -7,9 +7,9 @@ ARG DOCKER_IMAGE_NAME_TEMPLATE="mcr.microsoft.com/playwright:v%version%-jammy"
# === INSTALL Node.js ===

RUN apt-get update && \
# Install node18
# Install node16
apt-get install -y curl wget gpg && \
curl -sL https://deb.nodesource.com/setup_18.x | bash - && \
curl -sL https://deb.nodesource.com/setup_16.x | bash - && \
apt-get install -y nodejs && \
# Feature-parity with node.js base images.
apt-get install -y --no-install-recommends git openssh-client && \
Expand Down
2 changes: 1 addition & 1 deletion utils/linux-browser-dependencies/inside_docker/process.sh
Expand Up @@ -5,7 +5,7 @@ set +x
# Install Node.js

apt-get update && apt-get install -y curl && \
curl -sL https://deb.nodesource.com/setup_18.x | bash - && \
curl -sL https://deb.nodesource.com/setup_16.x | bash - && \
apt-get install -y nodejs

# Install apt-file
Expand Down

0 comments on commit 70065ba

Please sign in to comment.