Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick(#1400): fix: emit Page on load/DOMContentLoaded #1403

Merged
merged 1 commit into from Jul 5, 2022
Merged

cherry-pick(#1400): fix: emit Page on load/DOMContentLoaded #1403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions playwright/_impl/_frame.py
View file
Open in desktop
Expand Up @@ -100,14 +100,14 @@ def _on_load_state(
and hasattr(self, "_page")
and self._page
):
self._page.emit("load", self)
self._page.emit("load", self._page)
if (
not self._parent_frame
and add == "domcontentloaded"
and hasattr(self, "_page")
and self._page
):
self._page.emit("domcontentloaded", self)
self._page.emit("domcontentloaded", self._page)

def _on_frame_navigated(self, event: FrameNavigatedEvent) -> None:
self._url = event["url"]
Expand Down
8 changes: 8 additions & 0 deletions tests/sync/test_page.py
View file
Open in desktop
Expand Up @@ -76,3 +76,11 @@ def test_sync_stacks_should_work(page: Page, server: Server) -> None:
page.goto(server.EMPTY_PAGE)
assert exc_info.value.stack
assert __file__ in exc_info.value.stack


def test_emitted_for_domcontentloaded_and_load(page: Page, server: Server) -> None:
with page.expect_event("domcontentloaded") as dom_info:
with page.expect_event("load") as load_info:
page.goto(server.EMPTY_PAGE)
assert isinstance(dom_info.value, Page)
assert isinstance(load_info.value, Page)