Skip to content

Commit

Permalink
Temporarily use fork for starlette 0.21 release
Browse files Browse the repository at this point in the history
The 0.21 release resolves a frequent error on our fastapi version.

See:
encode/starlette#1710
encode/starlette#1715
  • Loading branch information
mmcfarland committed Oct 24, 2022
1 parent 72be508 commit be10fe5
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 3 deletions.
7 changes: 6 additions & 1 deletion pccommon/setup.py
Expand Up @@ -4,7 +4,12 @@

# Runtime requirements.
inst_reqs = [
"fastapi>=0.75.2",
# --->
# TODO: restore fastapi release install after starlette dep upgraded to >= 0.21.0
# "fastapi>=0.75.2",
"fastapi @ git+https://github.com/mmcfarland/fastapi/@982e7caf086bffeace8554da6d69e5f3082f14a3#egg=fastapi",
"starlette>=0.21.0,<0.22.0",
# <---
"opencensus-ext-azure==1.0.8",
"opencensus-ext-logging==0.1.0",
"orjson==3.5.2",
Expand Down
3 changes: 3 additions & 0 deletions pcfuncs/Dockerfile
@@ -1,5 +1,8 @@
FROM mcr.microsoft.com/azure-functions/python:4-python3.8

# git required for pip installs from git
RUN apt update && apt install -y git

ENV AzureWebJobsScriptRoot=/home/site/wwwroot \
AzureFunctionsJobHost__Logging__Console__IsEnabled=true

Expand Down
3 changes: 3 additions & 0 deletions pctiler/Dockerfile
@@ -1,5 +1,8 @@
FROM python:3.9-slim

# git required for pip installs from git
RUN apt update && apt install -y git

# The devops Personal Access Token for accessing
# Azure Artifacts. Note: This will be visible as
# plain text in the docker build logs. Only use your
Expand Down
4 changes: 2 additions & 2 deletions requirements-dev.txt
Expand Up @@ -6,8 +6,8 @@ openapi-spec-validator==0.3.0
cachetools<=4.2.
pytest==7.*
pytest-asyncio==0.18.*
httpx==0.19.0
httpx>=0.22.0

# Mypy types

types-cachetools
types-cachetools

0 comments on commit be10fe5

Please sign in to comment.