Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFT on DirectML #12710

Merged
merged 6 commits into from Sep 1, 2022
Merged

DFT on DirectML #12710

merged 6 commits into from Sep 1, 2022

Conversation

smk2007
Copy link
Member

@smk2007 smk2007 commented Aug 24, 2022

Add kernel implementation for DFT on DirectML.

sumitsays
sumitsays previously approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@sumitsays sumitsays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lgtm-com
Copy link

lgtm-com bot commented Aug 26, 2022

This pull request fixes 5 alerts when merging ed027de into a972db0 - view on LGTM.com

fixed alerts:

  • 5 for Uncontrolled data used in path expression

fdwr
fdwr reviewed Aug 27, 2022
View reviewed changes
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/Shaders/stockham.hlsl Outdated

uint3 idx = uint3(0, 0, 0);
idx.x = index / (OutputSizes[1] * OutputSizes[2]);
idx.y = temp / OutputSizes[2]; // This corresponds to the s1'th element of the dft
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s1

s1'th? 🤔
1st?

@wchao1115
Copy link

wchao1115 commented Aug 30, 2022 •
edited

Thanks @smk2007 for the work. It'll be super exciting to see this in Premier Pro audio scenarios at MAX this year. We should find a way to integrate this shader into DML in its next quarterly update.

fdwr
fdwr previously approved these changes Aug 30, 2022
View reviewed changes
@smk2007 smk2007 merged commit e3b5011 into main Sep 1, 2022
@smk2007 smk2007 deleted the user/sheilk/diectml-dft branch September 1, 2022 15:31
smk2007 added a commit that referenced this pull request Sep 7, 2022
@smk2007
DFT on DirectML (#12710)
2b9eba3 
* DFT on DirectML

* feedback

* fix misc build issues

* fixes

* fix constant cpu inputs and optional tensors for external operators

* disable dft tests on 'pure' dml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumitsays sumitsays sumitsays approved these changes

@fdwr fdwr fdwr left review comments

@jstoecker jstoecker Awaiting requested review from jstoecker

@adtsai adtsai Awaiting requested review from adtsai

@jeffbloo jeffbloo Awaiting requested review from jeffbloo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smk2007 @wchao1115 @fdwr @sumitsays