Skip to content

Commit

Permalink
Fix UnitTestingPkg misspells (#135)
Browse files Browse the repository at this point in the history
# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

These errors were found when trying to merge another PR. Making it more
sensical
to fix them in a designated change.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

No functional changes.

## Integration Instructions

N/A
  • Loading branch information
kuqin12 committed Jan 3, 2023
1 parent d8148e2 commit d669d8a
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 18 deletions.
Expand Up @@ -44,7 +44,7 @@ UINTN mMemoryInfoDatabaseAllocSize = 0;
**/
UNIT_TEST_STATUS
EFIAPI
NoReadWriteExcecute (
NoReadWriteExecute (
IN UNIT_TEST_CONTEXT Context
)
{
Expand Down Expand Up @@ -268,7 +268,7 @@ DxePagingAuditTestAppEntryPoint (
goto EXIT;
}

AddTestCase (Misc, "No pages can be read,write,execute", "Security.Misc.NoReadWriteExecute", NoReadWriteExcecute, NULL, NULL, Context);
AddTestCase (Misc, "No pages can be read,write,execute", "Security.Misc.NoReadWriteExecute", NoReadWriteExecute, NULL, NULL, Context);

//
// Execute the tests.
Expand Down
Expand Up @@ -105,7 +105,7 @@ ApIrqInterruptHandler (
}

/**
Archtectural initialization routine, allowing different CPU architectures
Architectural initialization routine, allowing different CPU architectures
to prepare their own register data buffer, data cache, etc.
@param NumOfCpus The number of CPUs supported on this platform.
Expand Down Expand Up @@ -553,7 +553,7 @@ CpuArchSleep (

/**
This routine will be used for disabling all the current interrupts,
but set up timer interrup to prepare for BSP suspension. It is only
but set up timer interrupt to prepare for BSP suspension. It is only
run by BSP.
@param Handle An EFI_HANDLE that is used for the BSP to
Expand Down Expand Up @@ -641,7 +641,7 @@ CpuArchDisableAllInterruptsButSetupTimer (

Status = EFI_SUCCESS;

// The timer will get caught by the original timer interrupt from the tiemr arch protocol
// The timer will get caught by the original timer interrupt from the timer arch protocol
Done:
if (EFI_ERROR (Status)) {
if (InterruptStates != NULL) {
Expand All @@ -655,7 +655,7 @@ CpuArchDisableAllInterruptsButSetupTimer (
}

/**
This routine will be used for retoring all the interrupts, from
This routine will be used for restoring all the interrupts, from
previously prepared EFI_HANDLE before BSP finishes timed suspension
routine. It is only run by BSP.
Expand Down
Expand Up @@ -24,8 +24,6 @@

#include "MpManagementInternal.h"

#define APFUNC_BUFFER_LEN 256

EFI_MP_SERVICES_PROTOCOL *mMpServices = NULL;
EFI_HANDLE mHandle = NULL;
UINTN mNumCpus = 0;
Expand Down
Expand Up @@ -40,11 +40,6 @@ typedef struct {
VOID *ApBuffer;
VOID *CpuArchBuffer;
} MP_MANAGEMENT_METADATA;

typedef struct {
EFI_MP_SERVICES_PROTOCOL *Mp;
CHAR16 **Buffer;
} APFUNC_ARG;
#pragma pack (pop)

extern UINTN mNumCpus;
Expand All @@ -64,7 +59,7 @@ ApFunction (
);

/**
Archtectural initialization routine, allowing different CPU architectures
Architectural initialization routine, allowing different CPU architectures
to prepare their own register data buffer, data cache, etc.
@param NumOfCpus The number of CPUs supported on this platform.
Expand Down Expand Up @@ -195,7 +190,7 @@ CpuArchWakeFromSleep (

/**
This routine will be used for disabling all the current interrupts,
but set up timer interrup to prepare for BSP suspension. It is only
but set up timer interrupt to prepare for BSP suspension. It is only
run by BSP.
@param Handle An EFI_HANDLE that is used for the BSP to
Expand All @@ -211,7 +206,7 @@ CpuArchDisableAllInterruptsButSetupTimer (
);

/**
This routine will be used for retoring all the interrupts, from
This routine will be used for restoring all the interrupts, from
previously prepared EFI_HANDLE before BSP finishes timed suspension
routine. It is only run by BSP.
Expand Down
5 changes: 4 additions & 1 deletion UefiTestingPkg/UefiTestingPkg.ci.yaml
Expand Up @@ -81,7 +81,10 @@
"ivhds",
"uefishelldebug",
"mtrrcap",
"dmaivrs"
"dmaivrs",
"MPIDR",
"ICDSGIR",
"SMRR",
],
"AdditionalIncludePaths": [] # Additional paths to spell check relative to package root (wildcards supported)
}
Expand Down
2 changes: 1 addition & 1 deletion UefiTestingPkg/UefiTestingPkg.dsc
Expand Up @@ -155,7 +155,7 @@
UefiTestingPkg/FunctionalSystemTests/MemoryProtectionTest/App/MemoryProtectionTestApp.inf

[Components.AARCH64]
# NOTE: These currently have source files that are only implemented for AACRH64.
# NOTE: These currently have source files that are only implemented for AARCH64.
# If needed on X86, should port (and test) the functions.
UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagement.inf

Expand Down

0 comments on commit d669d8a

Please sign in to comment.