Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OemPkg: DfciDeviceIdSupportLib: Fixing uninitialized variable being used #211

Merged
merged 2 commits into from
May 14, 2024

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented May 10, 2024

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

There are a few instances where the variables could be used without being initialized in DfciDeviceIdSupportLib. This change is made to fix such cases.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested on QEMU Q35 and booted to UEFI shell.

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact impact:security Has a security impact labels May 10, 2024
@kuqin12 kuqin12 requested review from cfernald, os-d and apop5 May 13, 2024 23:12
@kuqin12 kuqin12 enabled auto-merge (squash) May 13, 2024 23:25
@kuqin12 kuqin12 merged commit 6cd87ea into release/202311 May 14, 2024
11 checks passed
@kuqin12 kuqin12 deleted the fix_clang branch May 14, 2024 00:08
ProjectMuBot added a commit to microsoft/mu_tiano_platforms that referenced this pull request May 15, 2024
Introduces 13 new commits in [Common/MU_OEM_SAMPLE](https://github.com/microsoft/mu_oem_sample.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/e57f115ac16c10423e13e7cdfec0200a164e3d4a">e57f11</a> pip: update edk2-pytool-extensions requirement from ~=0.27.2 to ~=0.27.3 (<a href="https://github.com/microsoft/mu_oem_sample/pull/197">#197</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/39dfc53c3c411becb541a5d5997e8bf88c79aa8e">39dfc5</a> pip: update edk2-pytool-library requirement from ~=0.21.3 to ~=0.21.4 (<a href="https://github.com/microsoft/mu_oem_sample/pull/200">#200</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/0c3e22bde172167927148941e2208b5723d8c5da">0c3e22</a> Repo File Sync: prevent `rustup` from self-updating (<a href="https://github.com/microsoft/mu_oem_sample/pull/201">#201</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/f18293a88c87dbd331ada260c931d5bf6918e12d">f18293</a> pip: update edk2-pytool-library requirement from ~=0.21.4 to ~=0.21.5 (<a href="https://github.com/microsoft/mu_oem_sample/pull/202">#202</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/c83e0a3cd407f1280badd048d8612bc1842a9f15">c83e0a</a> Repo File Sync: Update to Mu DevOps 9.1.9 (<a href="https://github.com/microsoft/mu_oem_sample/pull/203">#203</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/0eb0b33c0dc3ac07e71a3863126ce631fd30c285">0eb0b3</a> Repo File Sync: Update to Ubuntu Container 0e124c1 (<a href="https://github.com/microsoft/mu_oem_sample/pull/204">#204</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/fd16af469cdc515e6ba66e75ac5079c37af7923f">fd16af</a> GitHub Action: Bump robinraju/release-downloader from 1.9 to 1.10 (<a href="https://github.com/microsoft/mu_oem_sample/pull/205">#205</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/a898620548ceae1fd0e38bcc51d6f77dd562c654">a89862</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_oem_sample/pull/206">#206</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/5a098b8279d21042aeec23cfc15e6654439fdaae">5a098b</a> pip: bump regex from 2023.12.25 to 2024.4.16 (<a href="https://github.com/microsoft/mu_oem_sample/pull/207">#207</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/b5bf4b4e6fed378a45d06baafc15b4d4b1c4a858">b5bf4b</a> GitHub Action: Bump robinraju/release-downloader from 1.9 to 1.10 (<a href="https://github.com/microsoft/mu_oem_sample/pull/208">#208</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/506b8e08ee0252b9226efe0f5477578a5deb6317">506b8e</a> pip: bump regex from 2024.4.16 to 2024.4.28 (<a href="https://github.com/microsoft/mu_oem_sample/pull/209">#209</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/7ee8c3382d8c64b8698c62ab6c3b97092e6b6199">7ee8c3</a> pip: update edk2-pytool-extensions requirement from ~=0.27.3 to ~=0.27.4 (<a href="https://github.com/microsoft/mu_oem_sample/pull/210">#210</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/6cd87eaaf2cc4ffabaafe2ae307e78e324c7c4b9">6cd87e</a> OemPkg: DfciDeviceIdSupportLib: Fixing uninitialized variable being used (<a href="https://github.com/microsoft/mu_oem_sample/pull/211">#211</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:security Has a security impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants