Skip to content

Commit

Permalink
OemPkg: Fix build (#121)
Browse files Browse the repository at this point in the history
## Description

Fix errors in several CI plugins to pass CI.

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

CI build.

## Integration Instructions

N/A

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
  • Loading branch information
makubacki committed Jul 14, 2023
1 parent d479c88 commit 746b442
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 22 deletions.
3 changes: 1 addition & 2 deletions OemPkg/HelloUefi/HelloUefi.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <Library/UefiApplicationEntryPoint.h>

// 30 seconds in microseconds
#define STALL_30_SECONDS 30000000
#define STALL_30_SECONDS 30000000

/**
The user Entry Point for Application. The user code starts with this function
Expand All @@ -34,7 +34,6 @@ UefiMain (
EFI_STATUS Status;

if (SystemTable == NULL) {

return EFI_INVALID_PARAMETER;
}

Expand Down
38 changes: 19 additions & 19 deletions OemPkg/HelloUefi/Readme.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
# Simple Bootable Media Example

Barebones example of how to boot to an EFI Application with no dependencies.

## Boot Directions

1. Format a usb drive as FAT32
2. At the root of this usb drive create the following folders: `EFI/Boot/`
3. Build and rename `HelloUefi.efi` as `boot<arch>.efi` and place at `EFI/BOOT/`

* IA32 - `bootx86.efi`
* AMD64 - `bootx64.efi`
* AARCH64 - `bootaa64.efi`

4. On your platform, boot into UEFI Menu and change the boot order to boot USB first
5. Turn off your platform
6. Plug in usb drive
7. Reboot
8. If successful, you should now see `Hello Uefi!` in the top left corner
# Simple Bootable Media Example

Barebones example of how to boot to an EFI Application with no dependencies.

## Boot Directions

1. Format a usb drive as FAT32
2. At the root of this usb drive create the following folders: `EFI/Boot/`
3. Build and rename `HelloUefi.efi` as `boot<arch>.efi` and place at `EFI/BOOT/`

* IA32 - `bootx86.efi`
* AMD64 - `bootx64.efi`
* AARCH64 - `bootaa64.efi`

4. On your platform, boot into UEFI Menu and change the boot order to boot USB first
5. Turn off your platform
6. Plug in usb drive
7. Reboot
8. If successful, you should now see `Hello Uefi!` in the top left corner
4 changes: 3 additions & 1 deletion OemPkg/OemPkg.ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@
"Passw", # Partial string for password name. Actual name is Passw0rd.
"OEM's",
"Bootxxxx",
"SECUREBOOT"
"SECUREBOOT",
"bootaa",
"bootx",
],
"AdditionalIncludePaths": [] # Additional paths to spell check relative to package root (wildcards supported)
}
Expand Down

0 comments on commit 746b442

Please sign in to comment.