-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute. #851
Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute. #851
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #851 +/- ##
==================================================
- Coverage 1.22% 1.22% -0.01%
==================================================
Files 1303 1303
Lines 335695 335701 +6
Branches 3189 3189
==================================================
Hits 4118 4118
- Misses 331501 331507 +6
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c2a1ce6
to
8565e3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add [CHERRY-PICK]
to the commit title that was cherry-picked from edk2? Additionally, can you wrap each of the changes in your commit with:
// MU_CHANGE BEGIN: Add EFI_MEMORY_SP
...
// MU_CHANGE END: Add EFI_MEMORY_SP
Or for single line changes:
...; // MU_CHANGE: Add EFI_MEMORY_SP
This helps us track what to upstream to edk2 and how to integrate it when we pull down new edk2 releases.
17caad8
to
ac542a9
Compare
Defined Encrypted and Special Purpose resource attributes as defined in PI 1.8 Specification Cc: Felix Polyudov <felixp@ami.com> Cc: Dhanaraj V <vdhanaraj@ami.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Signed-off-by: Sachin Ganesh <sachinganesh@ami.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE resource attribute as per the PI 1.8 spec. This flag is used to indicate that the memory should be treated as special purpose memory (SPM). Also adds GCD code that marks the SPM with the EFI_MEMORY_SP bit and sets the GCD memory type to EfiGcdMemoryTypeSystemMemory.
ac542a9
to
73fd883
Compare
Description
Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE resource attribute as per the PI 1.8 spec. This flag is used to indicate that the memory should be treated as special purpose memory (SPM).
Also adds GCD code that marks the SPM with the EFI_MEMORY_SP bit in the memory map and sets the GCD memory type to EfiGcdMemoryTypeSystemMemory.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
stuart_ci_build passed clean.
Manual testing using UEFI firmware on a device showed the expected behavior when HOBs are marked with EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE.
Integration Instructions
N/A