[Rebase & FF] Adding support for CLANGPDB build #848
Merged
+90
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #848 +/- ##
==================================================
- Coverage 1.22% 1.03% -0.19%
==================================================
Files 1304 1304
Lines 335782 335226 -556
Branches 3189 3006 -183
==================================================
- Hits 4118 3485 -633
+ Misses 331588 331300 -288
- Partials 76 441 +365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kuqin12
force-pushed
the
fix_clang
branch
3 times, most recently
from
ed7f3dc
to
bdced54
Compare
kuqin12
changed the title
|
need MU_CHANGE all over. |
kuqin12
force-pushed
the
fix_clang
branch
3 times, most recently
from
eb07578
to
88b895f
Compare
cfernald
approved these changes
Jun 6, 2024
This change adds the support for building AARCH64 target platforms using CLANDPDB. Cc: Rebecca Cran <rebecca@bsdio.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Bob Feng <bob.c.feng@intel.com> Cc: Yuwei Chen <yuwei.chen@intel.com> Cc: Leif Lindholm <quic_llindhol@quicinc.com> Co-authored-by: Chris Fernald <chfernal@microsoft.com> Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change removed a few directives unsupported by CLANDPDB. Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change removed directives unsupported by CLANGPDB. It also resovles a symbol not found error due to unsupported attributes. Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Signed-off-by: Kun Qin <kuqin@microsoft.com>
cfernald
approved these changes
Jun 6, 2024
apop5
approved these changes
Jun 6, 2024
Javagedes
approved these changes
Jun 6, 2024
This file is duplicate across multiple rebases. This change is added to remove it.
There could a path where the variable is used without being initialized. This change initialized the variable at the function entry. Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhichao Gao <zhichao.gao@intel.com> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Kun Qin <kuqin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.
Description
This change added the tools_def section for building AARCH64 target with CLANGPDB.
A few assembly files are fixed up to remove unsupported directives.
Lastly, an issue of uninitialized variable that might be used is fixed from DevicesPathLib.
For each item, place an "x" in between
[and]if true. Example:[x].(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
This change is tested on QEMU SBSA platform and booted to UEFI shell.
Integration Instructions
Platforms that would like to build with CLANGPDB should specify
TOOL_CHAIN_TAG=CLANGPDBto build with CLANGPDB.