RustEnvironmentCheck: Check for corrupted components #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
makubacki
commented
May 6, 2024
Running `rustup upgrade` tends to result in components becoming corrupted, particularly when the upgrade occurs in a VS Code prompt. This change adds a check to RustEnvironmentCheck to detect this condition and provide more helpful instructions. Previously, the generic instructions were displayed which do not fix the problem. See issue 2704 in https://github.com/rust-lang/rustup for more details. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
add_rustenvcheck_componentcheck
branch
from
e90ae35
to
0d17a7f
Compare
Javagedes
approved these changes
May 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #842 +/- ##
===============================================
Coverage 1.22% 1.22%
===============================================
Files 1303 1303
Lines 335685 335685
Branches 3183 3183
===============================================
Hits 4118 4118
Misses 331491 331491
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
May 6, 2024
srilathasridharan
pushed a commit
to srilathasridharan/mu_basecore
that referenced
this pull request
May 21, 2024
## Description Running `rustup upgrade` tends to result in components becoming corrupted, particularly when the upgrade occurs in a VS Code prompt. This change adds a check to RustEnvironmentCheck to detect this condition and provide more helpful instructions. Previously, the generic instructions were displayed which do not fix the problem. See issue 2704 in https://github.com/rust-lang/rustup for more details. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested - Verified the message is shown when the condition is present. - Verified the message is not shown when the condition is not present. ## Integration Instructions N/A Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running
rustup upgradetends to result in components becomingcorrupted, particularly when the upgrade occurs in a VS Code prompt.
This change adds a check to RustEnvironmentCheck to detect this
condition and provide more helpful instructions. Previously, the
generic instructions were displayed which do not fix the problem.
See issue 2704 in https://github.com/rust-lang/rustup for more
details.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Integration Instructions
N/A