Update GenFvInternalLib.c to no longer require file and section alignment for DXE #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment for DXE temp change to resolve this issue Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202302 #840 +/- ##
===============================================
Coverage 1.01% 1.01%
===============================================
Files 1278 1278
Lines 325549 325549
Branches 4792 4792
===============================================
Hits 3316 3316
Misses 322194 322194
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
os-d
reviewed
May 4, 2024
| //Error (NULL, 0, 3000, "Invalid", "PE image Section-Alignment and File-Alignment do not match : %s.", FileName); | ||
| //return EFI_ABORTED; | ||
| // mu change - avoid forcing DXE core and drivers to be XIP. | ||
| continue; |
There was a problem hiding this comment.
This is not the path we currently want to go, right? We should take a deeper look here, but can workaround this issue in the meantime.
There was a problem hiding this comment.
@spbrogan, are we good to abandon this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temp change to resolve this issue
Description
<Please include a description of the change and why this change was made.>
For each item, place an "x" in between
[and]if true. Example:[x].(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
N/A
Integration Instructions
N/A