Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup writeSQLVariant (removed unused parameter, remove duplicate code, spelling fixes) #2411

Merged
merged 5 commits into from
May 9, 2024

Conversation

Jeffery-Wasty
Copy link
Member

@Jeffery-Wasty Jeffery-Wasty commented May 8, 2024

Remove the unused bulkScale parameter in writeSQLVariant. Also some spelling and other small changes to this method since we have the chance to make changes.

Original issue was created to address missing cleanup from #747.

@Jeffery-Wasty Jeffery-Wasty added this to the 12.7.1 milestone May 8, 2024
@Jeffery-Wasty Jeffery-Wasty added this to In progress in MSSQL JDBC via automation May 8, 2024
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.25%. Comparing base (f312d1b) to head (d3fb49e).
Report is 1 commits behind head on main.

❗ Current head d3fb49e differs from pull request most recent head 8380c53. Consider uploading reports for the commit 8380c53 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2411      +/-   ##
============================================
+ Coverage     50.18%   50.25%   +0.07%     
- Complexity     3838     3868      +30     
============================================
  Files           145      145              
  Lines         33360    33355       -5     
  Branches       5654     5654              
============================================
+ Hits          16742    16763      +21     
- Misses        14228    14229       +1     
+ Partials       2390     2363      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

barryw-mssql
barryw-mssql previously approved these changes May 8, 2024
MSSQL JDBC automation moved this from Under Peer Review to In progress May 8, 2024
@Jeffery-Wasty Jeffery-Wasty changed the title Remove unused parameter in writeSQLVariant Cleanup writeSQLVariant (removed unused parameter, remove duplicate code, spelling fixes) May 8, 2024
@Jeffery-Wasty Jeffery-Wasty merged commit 357a0b5 into main May 9, 2024
17 checks passed
MSSQL JDBC automation moved this from In progress to Closed/Merged PRs May 9, 2024
@Jeffery-Wasty Jeffery-Wasty deleted the bulkScale branch May 9, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants