Execute stored procedures directly for RPC calls #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2410 +/- ##
============================================
+ Coverage 49.88% 50.20% +0.32%
- Complexity 3827 3840 +13
============================================
Files 145 145
Lines 33360 33353 -7
Branches 5654 5654
============================================
+ Hits 16642 16746 +104
+ Misses 14349 14210 -139
- Partials 2369 2397 +28 ☔ View full report in Codecov by Sentry. |
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Show resolved
Hide resolved
|
Noticed some minor formatting issues, please run formatter on files. |
lilgreenbird
previously approved these changes
May 14, 2024
Jeffery-Wasty
approved these changes
May 17, 2024
barryw-mssql
approved these changes
May 22, 2024
tkyc
added a commit
that referenced
this pull request
May 22, 2024
* RPC fix * Assertion index correction * Removed magic number * Removed login drop command * Code review changes * Formatting
Jeffery-Wasty
pushed a commit
that referenced
this pull request
May 22, 2024
…2427) * Fix calling procedures with output parameters by their four-part syntax (#2349) * Corrected four part syntax regression * JDK 8 correction * Execute stored procedures directly for RPC calls (#2410) * RPC fix * Assertion index correction * Removed magic number * Removed login drop command * Code review changes * Formatting * Test config changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC calls were falling back to old logic of being wrapped in sp_executesql calls to execute. With the PR, moving forward, RPC calls are also directly executed.