Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed applicationKey property in tests to applicationClientKey (to align with applicationClientID) #2399

Closed
wants to merge 1 commit into from

Conversation

lilgreenbird
Copy link
Member

No description provided.

@lilgreenbird lilgreenbird requested a review from tkyc April 23, 2024 22:41
@lilgreenbird lilgreenbird added this to In progress in MSSQL JDBC via automation Apr 23, 2024
@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.17%. Comparing base (f452337) to head (08f2ecb).

❗ Current head 08f2ecb differs from pull request most recent head f6e9098. Consider uploading reports for the commit f6e9098 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2399      +/-   ##
============================================
+ Coverage     49.88%   50.17%   +0.29%     
- Complexity     3827     3837      +10     
============================================
  Files           145      145              
  Lines         33360    33360              
  Branches       5654     5654              
============================================
+ Hits          16642    16740      +98     
+ Misses        14349    14228     -121     
- Partials       2369     2392      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilgreenbird lilgreenbird added this to the 12.7.1 milestone Apr 23, 2024
@lilgreenbird
Copy link
Member Author

this is no longer necessary

MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Apr 24, 2024
@Jeffery-Wasty Jeffery-Wasty deleted the removeapp branch May 8, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants